Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cider-stacktrace-navigate-to-other-window defcustom #3417

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Aug 19, 2023

By default, when you jump to the source of a given stack frame, an Emacs window other than that of *cider-error* will be chosen.

cider-stacktrace-navigate-to-other-window offers to remain in the same window instead.

@vemv vemv requested a review from bbatsov August 19, 2023 14:52
@@ -529,6 +529,12 @@ Achieved by destructively manipulating `cider-stacktrace-suppressed-errors'."
(button-put button 'help-echo "Click to promote these stacktraces."))
(button-put button 'suppressed (not suppressed)))))

(defcustom cider-stacktrace-navigate-to-other-window t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably move this next to the other defcustoms.

[source,lisp]
----
(setq cider-stacktrace-navigate-to-other-window nil)
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to throw some tip to use C-x arrow if they pick this setting. (see https://stackoverflow.com/questions/71248133/going-back-to-a-previous-buffer-in-emacs)

I'm assuming that unless people know this they won't understand why this setting makes sense.

@vemv vemv force-pushed the cider-stacktrace-navigate-to-other-window branch from ccb9574 to bf3362c Compare August 20, 2023 11:02
@vemv
Copy link
Member Author

vemv commented Aug 20, 2023

All done. Thanks!

@vemv vemv merged commit 8bb19a9 into master Aug 20, 2023
26 checks passed
@vemv vemv deleted the cider-stacktrace-navigate-to-other-window branch August 20, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants