Introduce cider-stacktrace-navigate-to-other-window defcustom
#3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Aug 20, 2023
cider-stacktrace.el
Outdated
| @@ -529,6 +529,12 @@ Achieved by destructively manipulating `cider-stacktrace-suppressed-errors'." | |||
| (button-put button 'help-echo "Click to promote these stacktraces.")) | |||
| (button-put button 'suppressed (not suppressed))))) | |||
|
|
|||
| (defcustom cider-stacktrace-navigate-to-other-window t | |||
There was a problem hiding this comment.
I'd probably move this next to the other defcustoms.
bbatsov
reviewed
Aug 20, 2023
| [source,lisp] | ||
| ---- | ||
| (setq cider-stacktrace-navigate-to-other-window nil) | ||
| ---- |
There was a problem hiding this comment.
Might be useful to throw some tip to use C-x arrow if they pick this setting. (see https://stackoverflow.com/questions/71248133/going-back-to-a-previous-buffer-in-emacs)
I'm assuming that unless people know this they won't understand why this setting makes sense.
vemv
force-pushed
the
cider-stacktrace-navigate-to-other-window
branch
from
ccb9574
to
bf3362c
Compare
|
All done. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, when you jump to the source of a given stack frame, an Emacs window other than that of
*cider-error*will be chosen.cider-stacktrace-navigate-to-other-windowoffers to remain in the same window instead.