Make jump-to-definition work in projects needing cider-path-translations
#3414
Conversation
| @@ -0,0 +1,9 @@ | |||
| FROM clojure:temurin-17-lein-bullseye | |||
There was a problem hiding this comment.
(This is a different Dockerfile from that of #3412)
|
@bbatsov rebased and green now |
…ions` i.e. Dockerized projects. Fixes #3413
| (when debug | ||
| (list file "was not determined to belong to classpath:" classpath "or classpath-roots:" classpath-roots))))))) | ||
|
|
||
| (defun cider-debug-sesman-friendly-session-p () |
There was a problem hiding this comment.
Why is this named as a predicate?
You might want to mention it somewhere in the troubleshooting/sesman docs.
There was a problem hiding this comment.
Why is this named as a predicate?
Funny you ask, I intended it to read debug(sesman-friendly-session-p) i.e. the -p is for the thing being debugged.
Alternative welcome.
Good call on adding it to the manual!
| @@ -286,22 +286,38 @@ in the container, the alist would be `((\"/src\" \"~/projects/foo/src\"))." | |||
| :group 'cider | |||
| :package-version '(cider . "0.23.0")) | |||
|
|
|||
| (defun cider--translate-path (path direction) | |||
| "Attempt to translate the PATH in the given DIRECTION. | |||
| (defun cider--translate-path (path direction &optional return-all) | |||
There was a problem hiding this comment.
Can you remind me why we can have multiple mappings for the same path? I never used TRAMP, so I don't remember very well how this was supposed to work.
There was a problem hiding this comment.
Generally we don't expect that to be the case, however I'm using the new cider--all-path-translations function (it has a comment justifying its existence) which gets the buffer-local cider-path-translations value from all buffers.
I imagine it's possible that some unrelated buffer's cider-path-translations can unexpectedly work for a given path.
So by specifying return-all, we get all possible matches - good and bad ones. Later, in the 'friendly session' computation, we compare them against the classpath. The bad ones won't matter - they won't be found in the classpath, so nothing is changed.
There was a problem hiding this comment.
Seems overly complicated to me, but given that I don't use or care about this functionality I'll assume you know what you're doing. :-)
There was a problem hiding this comment.
I wish it could be less complicated. 😄
|
Thanks! |
The gist of it is:
cider--file-path, as invoked fromcider-find-file), we translate paths in the opposite direction.Cheers - V