-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up test suite #3403
Clean up test suite #3403
Conversation
These can be confusing.
This ensures their execution is displayed on CI.
Finally I added a fix for #3402 . It's a bit unrelated to this PR's theme, but small enough to let it slip (hopefully) |
`(,spec-char | ||
. | ||
,(if (symbolp spec-value) | ||
(prin1-to-string spec-value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoids this code path https://github.com/emacs-mirror/emacs/blame/d3dae88e6cc8118c875957ba0347be9599014b34/lisp/format-spec.el#L110
e.g. if the user had a function named clj
, we change it from symbol to string, so that it's not functionp
anymore.
I was able to reproduce this scenario on CI, verifying that the tests would fail if we remove this fix.
Nice improvements! |
Commits:
provide
s in testsit
more*tests.el
namingit
blocksmaster
), but now we will run 29 stable and 29 master (which will become 30 at some point, I guess)cider-format-connection-params
cider-format-connection-params
edge case for Emacs 29Cheers - V