Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up test suite #3403

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Clean up test suite #3403

merged 8 commits into from
Aug 18, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Aug 12, 2023

Commits:

Cheers - V

@vemv vemv requested a review from bbatsov August 12, 2023 13:44
@vemv
Copy link
Member Author

vemv commented Aug 12, 2023

Finally I added a fix for #3402 . It's a bit unrelated to this PR's theme, but small enough to let it slip (hopefully)

`(,spec-char
.
,(if (symbolp spec-value)
(prin1-to-string spec-value)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoids this code path https://github.com/emacs-mirror/emacs/blame/d3dae88e6cc8118c875957ba0347be9599014b34/lisp/format-spec.el#L110

e.g. if the user had a function named clj, we change it from symbol to string, so that it's not functionp anymore.

I was able to reproduce this scenario on CI, verifying that the tests would fail if we remove this fix.

@bbatsov bbatsov merged commit 9d1c3cd into master Aug 18, 2023
26 checks passed
@bbatsov bbatsov deleted the cleanup-test-suite branch August 18, 2023 09:40
@bbatsov
Copy link
Member

bbatsov commented Aug 18, 2023

Nice improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants