-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cider-clojurec-eval-destination
custom variable
#3387
Add cider-clojurec-eval-destination
custom variable
#3387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks much!
I mainly suggested removing the nil
choice which can simplify things.
Cheers - V
The new defcustom should also be mentioned in the user manual. |
Where should this be added exactly? |
Apart from my small remarks the changes look good. You might also want to squash those commits together. |
Commits squashed 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing and it's in 👍
cider-clojurec-eval-destination
custom variable
Adds a cider-clojurec-repl-type-override variable to allow overriding the default behavior of sending CLJC evals to both CLJ and CLJS.
Also includes a cider-set-clojurec-repl-type-override function to prompt the user to set this variable local to the buffer
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.