-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(70): SQL spec for 1.0 #71
base: master
Are you sure you want to change the base?
Conversation
42b54e2
to
4f000d5
Compare
@@ -1,407 +0,0 @@ | |||
# SQL Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, I deleted this file and replaced it with a new one for an easier to review diff. I'm not sure if this will render. I will rename back to index.md
before merging.
|
||
> **CREATE TABLE** _table_name_ (_column_name_ _data_type_, ...); | ||
|
||
![create-table](/images/syntax/create_table.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images point to the spacetime-web repo. Which means they don't render here.
4ccb7c6
to
c03adb3
Compare
c03adb3
to
4bc0557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this LGTM, but wait for a native review.
|
||
-- Delete all rows with a specific item_id | ||
DELETE FROM Inventory WHERE item_id = 1; | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the examples!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mamcx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with various nits mentioned throughout. The only thing I would consider more deeply is whether unquoted identifiers really need to be case insensitive.
5b79e60
to
1dda5b1
Compare
Closes #70.
1dda5b1
to
5a044bd
Compare
I'm waiting to merge this until, at the very least, the spec as been fully implemented, since merging to master automatically deploys doc changes. |
NOTE: There are some sql tickets scheduled for 1.0, so I'm moving this to 1.0. It can be merged to master anytime after 0.12 is released. It won't be deployed until it's incorporated into the release branch. |
No description provided.