-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release - Fix path traversal bug for sqlite, new clickhouse options, and support for OpenAI-like URLs #329
Open
modelorona
wants to merge
36
commits into
release
Choose a base branch
from
main
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
898d894
add openai compatible provider
b12bc69
Merge branch 'clidey:main' into main
learningpro 15fa9ca
Merge branch 'main' into main
learningpro 95026e8
add additional options for clickhouse support, HTTP protocol, TLS mod…
Slach 1411fcf
Merge pull request #300 from Slach/main
hkdeman b994967
Merge pull request #252 from learningpro/main
hkdeman 27f106b
fix variant A and B for path traversal
modelorona cb5b9bf
remove string processing code
modelorona cfda05a
update directory to end with slash
modelorona 9c15d79
initial fix for mysql to use the driver Config object to build the ds…
modelorona cb871a0
change to hostPath check to account for length
modelorona 380544c
removed the hostPath for now. removed & from collation before passing…
modelorona 9e8669a
add back func for reading in params behind isProfile guard
modelorona 903c223
postgres dsn builder surrounds all params with single quotes now to t…
modelorona f2d6de1
redis addr built using net.JoinHostPort
modelorona dd94d97
modify mongodb to connect using clientOptions
modelorona 520d862
query escape for elasticsearch
modelorona 33a56d1
disable clickhouse sslmode as it's not fully complete. update elastic…
modelorona 3f6fcab
Update issue templates
modelorona 547336a
Merge commit from fork
modelorona 0e75ff3
parse port as num and fail otherwise, remove collation option from fr…
modelorona 6f1ebf3
update clickhouse config
modelorona 2d47a83
update postgres handling to escape all single quotes to avoid jumping…
modelorona 5978412
fix clickhouse setup to allow for both port 9000 (tcp) and port 8123 …
modelorona 8d67b76
Merge commit from fork
modelorona f67f843
feat(core,frontend): add alias logic
hkdeman 76e0cad
Merge pull request #331 from clidey/hk/issues/alias
hkdeman e2f0ed9
feat(frontend): fix table header logic to have unique ids
hkdeman 114522f
feat(frontend): fix up undefined
hkdeman 410561a
Merge pull request #332 from clidey/hk/issues/scratchpad-wrong-columns
hkdeman bef215f
feat(frontend): replace monaco editor with code mirror for offline pa…
hkdeman df37d60
feat(editor): fix theming
hkdeman e7d8228
feat(frontend): fix markdown library issue
hkdeman c27f796
Merge pull request #333 from clidey/hk/issues/switch-to-code-mirror
hkdeman 46a7956
feat(frontend): add loader and loading states
hkdeman e19fe5a
Revert "feat(frontend): add loader and loading states"
hkdeman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
Copilot Autofix AI 7 days ago
To fix the problem, we need to ensure that user input is safely embedded into the SQL query. This can be achieved by using parameterized queries or prepared statements. In this case, we will use parameterized queries to avoid SQL injection vulnerabilities.
AddStorageUnit
function to use parameterized queries for theschema
andstorageUnit
parameters.sql.Named
to safely include theschema
andstorageUnit
parameters in the query.