misc: Fix some problems codacy detected.

clibs · Mar 26, 2021 · 8adc255 · 8adc255
1 parent a5adbcf
commit 8adc255
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/src/clib-install.c b/src/clib-install.c
@@ -421,7 +421,7 @@ int main(int argc, char *argv[]) {
 
   clib_cache_init(CLIB_PACKAGE_CACHE_TIME);
 
-  clib_package_opts_t install_package_opts;
+  clib_package_opts_t install_package_opts = {0};
   install_package_opts.skip_cache = opts.skip_cache;
   install_package_opts.prefix = opts.prefix;
   install_package_opts.global = opts.global;

diff --git a/src/clib-update.c b/src/clib-update.c
@@ -351,13 +351,13 @@ int main(int argc, char *argv[]) {
   clib_cache_init(CLIB_PACKAGE_CACHE_TIME);
 
   package_opts.skip_cache = 1;
-  package_opts.prefix = package_opts.prefix;
+  package_opts.prefix = opts.prefix;
   package_opts.global = 0;
   package_opts.force = 1;
-  package_opts.token = package_opts.token;
+  package_opts.token = opts.token;
 
 #ifdef HAVE_PTHREADS
-  package_opts.concurrency = package_opts.concurrency;
+  package_opts.concurrency = opts.concurrency;
 #endif
 
   clib_package_set_opts(package_opts);

diff --git a/src/common/clib-package-installer.c b/src/common/clib-package-installer.c
@@ -507,7 +507,8 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
     }
 
 #if defined(__unix__) || (defined(__APPLE__) && defined(__MACH__))
-    usleep(1024 * 10);
+    struct timespec ts = {0, 1000*1000*10};
+    nanosleep(&ts, NULL);
 #endif
 
 #ifdef HAVE_PTHREADS

diff --git a/src/registry/registry.c b/src/registry/registry.c
@@ -62,6 +62,8 @@ registry_ptr_t registry_create(const char *url, const char *secret) {
   } else if (strstr(url, "gitlab") != NULL) {
     registry->type = REGISTRY_TYPE_GITLAB;
   } else {
+    registry_free(registry);
+
     return NULL;
   }