Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle empty response body #162

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

fix: handle empty response body #162

wants to merge 2 commits into from

Commits on May 19, 2024

  1. test: adds a tests that showcases #161 

    This shows that returning an empty body, with a non-error status code
will break DoWithContext because it will try to unmarshal an invalid
JSON string.
    @nobe4
    nobe4 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    20b3d72 View commit details
    Browse the repository at this point in the history

  2. fix: add check for empty response body 

    This ensures that an empty response body, which is valid and present in
some endpoints.
    @nobe4
    nobe4 committed May 19, 2024
    Configuration menu
    Copy the full SHA
    702451a View commit details
    Browse the repository at this point in the history