Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Ruby documentation for 4.0 release #1926

Merged
merged 11 commits into from
Jan 28, 2025
Merged

feat: Update Ruby documentation for 4.0 release #1926

merged 11 commits into from
Jan 28, 2025

Conversation

tmilewski
Copy link
Member

@tmilewski tmilewski commented Jan 17, 2025

Explanation:

  • Adds/Updates relevant information for the v4.0 Ruby SDK release.
  • Adds script "lint:formatting:fix"

Fixes ECO-325

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

@tmilewski tmilewski self-assigned this Jan 17, 2025
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1926

@tmilewski tmilewski marked this pull request as ready for review January 22, 2025 19:10
@tmilewski tmilewski requested a review from a team as a code owner January 22, 2025 19:10
@alexisintech
Copy link
Member

alrighty, I've done a review but there's a lot of questions we gotta go over because I'm just not familiar with ruby at alllll!! but I've done the best I can, and look forward to hopping in a call 🫶

  • Removed the installation steps from the /overview into a Ruby quickstart
  • Removed the /available-methods page altogether
  • Cleaned up the copy and code on the other pages
  • Added a bunch of TODO's!

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for collaborating with me on these and answering all my questions (I know they can be a lot) these docs are looking great 😸💖

@tmilewski
Copy link
Member Author

thank you for collaborating with me on these and answering all my questions (I know they can be a lot) these docs are looking great 😸💖

@tmilewski tmilewski merged commit 8babeca into main Jan 28, 2025
4 checks passed
@tmilewski tmilewski deleted the tm/ruby branch January 28, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants