Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Router 7 compatilibty issue callout #1866

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jan 8, 2025

Screenshot 2025-01-08 at 3 07 36 PM

Explanation:

This PR:

  • Adds warning callout to React Router quickstart and overview pages informing users to use Node.js 22.11 or lower

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link

github-actions bot commented Jan 8, 2025

Hey, here’s your docs preview: https://clerk.com/docs/pr/1866

@wobsoriano wobsoriano marked this pull request as ready for review January 8, 2025 23:07
@@ -4,7 +4,7 @@ description: Learn how to integrate Clerk into your React Router application usi
---

> [!WARNING]
> The React Router SDK is currently in beta.
> Due to an upstream issue with [React Router](https://github.com/remix-run/react-router/issues/12475), you'll need to use Node.js 22.11 or lower until the issue is resolved.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where's the best place to put another callout so I had to remove the current one, multiple warnings stacked looks weird 🤔 Feel free to update!

docs/quickstarts/react-router.mdx Outdated Show resolved Hide resolved
docs/references/react-router/overview.mdx Outdated Show resolved Hide resolved
wobsoriano and others added 2 commits January 8, 2025 18:02
Co-authored-by: Colin Sidoti <[email protected]>
Co-authored-by: Colin Sidoti <[email protected]>
@wobsoriano wobsoriano merged commit 17e7c42 into main Jan 9, 2025
4 checks passed
@wobsoriano wobsoriano deleted the react-router-7-issue-callout branch January 9, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants