Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Library Grouping to have "Album Artist / Album" #190

Merged
merged 4 commits into from
Apr 13, 2018

Conversation

physk
Copy link
Contributor

@physk physk commented Apr 12, 2018

Translations string XML files have been updated with the additional item under "pref_library_grouping_values" with my best guess at the translations. They have been commented, For someone who is multi-lingual to fix if needed :)

Translations string XML files have been updated with the additional item under "pref_library_grouping_values" with my best guess at the translations. They have been commented, For someone who is multi-lingual to fix if needed :)
@amuttsch
Copy link
Member

Looks good. Please remove all translations as they will be overridden by the next transifex translation pull. Also add the feature to the CHANGELOG file.

@physk
Copy link
Contributor Author

physk commented Apr 12, 2018

@amuttsch There that should be done now :) Sorry i forgot to tick all the translation files when i committed (Hence the double commit)

@amuttsch
Copy link
Member

Perfect, thanks for the PR :)

@amuttsch amuttsch merged commit df3d028 into clementine-player:master Apr 13, 2018
@remjg
Copy link

remjg commented Feb 26, 2020

I was looking for the very interesting "album artist" grouping feature on Clementine Remote v12, until I realised I needed to set up my phone in English language to see the option. Seems like something went wrong, at least for the French translation.

#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants