Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run contract tests as part of CI #341

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Run contract tests as part of CI #341

merged 3 commits into from
Jan 7, 2021

Conversation

dtebbs
Copy link
Contributor

@dtebbs dtebbs commented Dec 21, 2020 •
edited
Loading

This is a step closer to full integration tests.

  • launch a ganache instance and runs all the contract tests in the python client
  • separate contact-only tests in python client (single command to run all contract tests)
  • use caching to make the client and contract checks faster

@dtebbs dtebbs force-pushed the ci-contract-tests branch 7 times, most recently from 2b65b9f to 1e02f24 Compare December 22, 2020 11:48
@dtebbs dtebbs force-pushed the ci-contract-tests branch 2 times, most recently from 792946f to 70fd5b7 Compare January 4, 2021 10:27
@dtebbs dtebbs changed the title [WIP] Ci contract tests Run contract tests as part of CI Jan 4, 2021
AntoineRondelet
AntoineRondelet reviewed Jan 6, 2021
View reviewed changes
client/test_contracts/__init__.py Outdated Show resolved Hide resolved
client/test_contracts/test_bls12_377_contract.py Outdated Show resolved Hide resolved
.github/workflows/onpush-checks.yml Show resolved Hide resolved
@dtebbs dtebbs mentioned this pull request Jan 6, 2021
Merged
@dtebbs dtebbs force-pushed the ci-contract-tests branch from 70fd5b7 to 46427f3 Compare January 7, 2021 10:05
@dtebbs dtebbs force-pushed the ci-contract-tests branch from 46427f3 to b8e15ab Compare January 7, 2021 10:06
@dtebbs dtebbs requested a review from AntoineRondelet January 7, 2021 10:08
AntoineRondelet
AntoineRondelet approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good to have more things delegated to the CI, thanks @dtebbs

@AntoineRondelet AntoineRondelet merged commit b6d2286 into develop Jan 7, 2021
@AntoineRondelet AntoineRondelet deleted the ci-contract-tests branch January 18, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet