forked from infofiend/Hue-Lights-Groups-Scenes
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from original #3
Open
claytonjn
wants to merge
95
commits into
claytonjn:master
Choose a base branch
from
infofiend:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SmartThings Color Temperature capability
Add transition time slider to Lux/White bulbs
… second setColorTemperature with transitiontime parameter.
This adds a setting for a default transition time variable, allowing the user to select what they want as default during the initial setup.
Uses the default transition time from the parent SmartApp when no transition time is specified.
Uses the default transition time from the parent SmartApp when no transition time is specified.
Uses the default transition time from the parent SmartApp when no transition time is specified.
Change colorTemp to the standard SmartThings attribute colorTemperature. http://docs.smartthings.com/en/latest/capabilities-reference.html?highlight=capability#color-temp
Change colorTemp to the standard SmartThings attribute colorTemperature. http://docs.smartthings.com/en/latest/capabilities-reference.html?highlight=capability#color-temp
Set default transition time when initially connecting to Hue
Change attribute to colorTemperature
Add functions that exist in the official SmartThings Service Manager/Device Handlers, but not here. These may or may not be needed, but things seems to reference them and it won't hurt to have them.
Re-order functions to align better with the default SmartThings Service Manager and Device Handlers. This will make it easier to incorporate upstream changes.
For some reason I thought the SmartThings team added Color Temperature to the Hue Lux/White device Handler. While merging upstream changes, I accidentally added this. Remove it, because those bulbs don't actually have that capability.
We always want to update the state for whatever the command was specifically for, but everything else can determine changes automatically. For example, if we send off() we want the status to confirm that the device is off even if it already was, but it only needs to show that effect is none if it was previously colorloop.
Clean up events further, changing when things are displayed in the notification stream.
Use custom descriptions so that the device name isn't repeated.
I thought displayed: false just hid it from the recently stream...didn't realize it also prevented the tile from updating without leaving and re-entering device.
Device states were not updating if changed from outside of SmartThings, and the refresh command was not working.
Did excessive testing, completely removing all Hue devices, and uninstalling the Service Manager and Device Handlers from the IDE. I used the IDE GitHub integration on claytonjn-Development branch to install everything from scratch. Bulbs, groups, and scenes all showed up properly, and I tested that all functionality is working.
version 1.4
Version 1.4: Added ability to create / modify / delete Hue Hub Scenes directly from SmartApp Overhauled communications to / from Hue Hub Revised child app functions
Info fiend development
… HLGS Scene ON / Lights or Groups OFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.