Call BW::Device explicitly instead of Device #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the assumption that Device == BW::Device to prevent errors if Device has already been defined.
|
This makes a lot of sense, regardless of the outcome of rubymotion-community/BubbleWrap#355. Thanks! |
clayallsopp
added a commit
that referenced
this pull request
Mar 27, 2014
Call BW::Device explicitly instead of Device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the assumption that Device == BW::Device to prevent errors if Device has already been defined.
I'm not sure if this is necessary. Though for my own builds, it's breaking because I already have a class Device defined. This causes Formotion to call my defined Device class rather than BW::Device.
I hope that helps.