Remove use of &/to_proc syntactic sugar since it causes RubyMotion to leak #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eak via malloc or the underlying object that is to_proc'd
|
Wow, that's surprising. Good call! Do you have a link to the HipByte ticket!? |
|
*didnt mean ?!, just ?. |
|
They haven't created an issue for it yet. I will post it when it is available and then decide whether to merge at this point. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've submitted the issue with the RubyMotion team and I'm sure they'll look into it and address it. Until then this pull request removes the use of the &/to_proc syntactic sugar as it causes a
mallocleak in the underlying RubyMotion code.It leaks 16 bytes each time sub_render is called. Admittedly, that isn't too much. But, it is still a leak.