Skip to content

Commit

Permalink
Fix phpcs build error on graphql disable session error
Browse files Browse the repository at this point in the history
  • Loading branch information
Lukasz Pawinski committed Nov 15, 2023
1 parent efb02e0 commit 94440fc
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
fail-fast: false
matrix:
php:
- "7.4"
- "8.1"
- "8.2"
steps:
- name: "Checkout"
uses: "actions/checkout@v3"
Expand Down
3 changes: 2 additions & 1 deletion Model/Info/RequestInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ public function getStatusCode(): int
*/
public function getSessionAttributes(): array
{
return session_status() ? $_SESSION : []; // phpcs:ignore Magento2.Security.Superglobal.SuperglobalUsageError
// phpcs:ignore Magento2.Functions.DiscouragedFunction.Discouraged,Magento2.Security.Superglobal.SuperglobalUsageError
return session_status() ? $_SESSION : [];
}

public function getPathInfo(): string
Expand Down
4 changes: 2 additions & 2 deletions Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ Module for debugging Magento 2 performance. It works without overwriting any cor
All settings have only default scope and config type pool is set to environment for better integration with `php bin/magento app:config:dump`

## Compatibility
* Magento 2.4
* PHP 7.4, 8.1
* Magento >= 2.4.4
* PHP 8.1, 8.2

## Profiler collectors
- Ajax
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"AFL-3.0"
],
"require": {
"php": ">=7.4",
"php": ">=8.1",
"magento/framework": "~103.0",
"magento/module-backend": "~102.0",
"magento/module-developer": "^100.4",
Expand All @@ -17,16 +17,16 @@
"symfony/stopwatch": "^2.8 || ^3.0 || ^4.0 || ^5.0"
},
"require-dev": {
"bitexpert/phpstan-magento": "^0.28.0",
"bitexpert/phpstan-magento": "^0.29.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
"magento/magento-coding-standard": "*",
"phpcompatibility/php-compatibility": "^9.3",
"phpmd/phpmd": "^2.9.1",
"phpstan/phpstan": "~1.9.0",
"phpstan/phpstan": "~1.10.41",
"phpunit/phpunit": "~9.5.0",
"sebastian/phpcpd": "^6.0.3",
"slevomat/coding-standard": "~6.4.1",
"squizlabs/php_codesniffer": "~3.6.0",
"squizlabs/php_codesniffer": "~3.7.2",
"phpstan/phpstan-phpunit": "^1.1.1"
},
"repositories": [
Expand Down

0 comments on commit 94440fc

Please sign in to comment.