fix: ensure delta correct for transforms and size changes #1527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing an issue introduced in 682db33, which broke the sizeDelta calculation for cases where the droppable changes size.
This change is the culprit
Which be reverted by inverting the arithmetic
This PR initially seemed to address the issue, but upon further inspection, I noticed it does not behave consistently, noticeable on smaller transform sizes (
0.5
) or when using keyboard sensor. This is a bad smell and indicates to me that I haven't understood the underlying logic.I've been slowly stepping through the Feedback sensor and making adjustments locally to get my head around how the transforms are being applied, but it's taking me a while as I'm struggling to understand how the transformed are being reasoned about.
Sharing this PR for progress, but marking as draft.