Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure delta correct for transforms and size changes #1527

Draft
wants to merge 1 commit into
base: experimental
Choose a base branch
from

Conversation

chrisvxd
Copy link

Attempt at fixing an issue introduced in 682db33, which broke the sizeDelta calculation for cases where the droppable changes size.

This change is the culprit

     const sizeDelta = {
        width:
          (initialSize.width / initialFrameTransform.scaleX -
            width / frameTransform.scaleX) *
          transformOrigin.x,
        height:
          (initialSize.height / initialFrameTransform.scaleY -
            height / frameTransform.scaleY) *
          transformOrigin.y,
      };

Which be reverted by inverting the arithmetic

     const sizeDelta = {
        width:
          (width / frameTransform.scaleX - initialSize.width / initialFrameTransform.scaleX) *
          transformOrigin.x,
        height:
          (height / frameTransform.scaleY - initialSize.height / initialFrameTransform.scaleY) *
          transformOrigin.y,
      };

This PR initially seemed to address the issue, but upon further inspection, I noticed it does not behave consistently, noticeable on smaller transform sizes (0.5) or when using keyboard sensor. This is a bad smell and indicates to me that I haven't understood the underlying logic.

I've been slowly stepping through the Feedback sensor and making adjustments locally to get my head around how the transforms are being applied, but it's taking me a while as I'm struggling to understand how the transformed are being reasoned about.

Sharing this PR for progress, but marking as draft.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 96b84a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant