Allow sortable animations across groups

clauderic · Sep 21, 2024 · 5b36f8f · 5b36f8f
1 parent 92676b4
commit 5b36f8f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/.changeset/sortable-group-aniamtion.md b/.changeset/sortable-group-aniamtion.md
@@ -0,0 +1,5 @@
+---
+'@dnd-kit/dom': patch
+---
+
+Allow sortable animations when changing to a different group even when the index remains the same.
diff --git a/packages/dom/src/sortable/sortable.ts b/packages/dom/src/sortable/sortable.ts
@@ -131,20 +131,13 @@ export class Sortable<T extends Data = Data> {
           () => {
             const {index, group, previousIndex, manager: _} = this;
 
-            if (group !== previousGroup) {
-              previousGroup = group;
+            // Re-run this effect whenever the index changes
+            if (index !== previousIndex || group !== previousGroup) {
               this.previousIndex = index;
-              return;
-            }
+              previousGroup = group;
 
-            // Re-run this effect whenever the index changes
-            if (index === previousIndex) {
-              return;
+              this.animate();
             }
-
-            this.previousIndex = index;
-
-            this.animate();
           },
           () => {
             const {target} = this;