Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing grpc register of query for dyncomm #380

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

StrathCole
Copy link
Collaborator

Summary of changes

added query to grpc

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@fragwuerdig
Copy link
Collaborator

The regeneration of market/oracle/treasury types should not be part of this PR...

@StrathCole
Copy link
Collaborator Author

The regeneration of market/oracle/treasury types should not be part of this PR...

Sure. Will revert that commit later and only commit the relevant.
I think depending on the version of protoc you have, it generates different proto go files. Technically the same, but different coding style. 😔

@StrathCole
Copy link
Collaborator Author

@fragwuerdig Reverted and added only changed query proto files. Update on rebel-2 validator worked.

@fragwuerdig fragwuerdig merged commit 56037e7 into main Nov 8, 2023
16 checks passed
@fragwuerdig fragwuerdig deleted the dyncomm-grpc-fix branch November 8, 2023 20:35
@fragwuerdig
Copy link
Collaborator

Happy With This - Thanks @StrathCole

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants