Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new layouts #25

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

sroussey
Copy link
Contributor

@sroussey sroussey commented Feb 4, 2024

This adds some new layouts. Uses a graph library for DAGs that I have been working on.

image

Copy link
Owner

@clarkmcc clarkmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! These layout engines can't be used without exporting through the lib/index.ts file though.

As a side note, I'm wondering if in the future we need to expose a better API for using builtin layout engines, since you have to work with those long function names like computePipelineLayout or computeDagreLayout and then assign them to a name, and then reference that name when calling the layout function. Check out my ChatGPT conversation about a possible type-safe design.

In any case, I'm approving assuming an export of the layout functions. I just wanted to regurgitate some of my thoughts so that they can guide design decisions in the future.

@sroussey
Copy link
Contributor Author

sroussey commented Feb 5, 2024

I refactored, so have a look.

@sroussey
Copy link
Contributor Author

sroussey commented Feb 5, 2024

Also, I needed a graph lib, and typescript-graph was the first I found. It is simple, but ended up being too simple so I forked it to add the things I need and is used in this PR as @sroussey/typescript-graph

Copy link
Owner

@clarkmcc clarkmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@clarkmcc clarkmcc merged commit fa3a046 into clarkmcc:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants