Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try refactor distances #322

Merged
merged 15 commits into from
Oct 3, 2022
Merged

Try refactor distances #322

merged 15 commits into from
Oct 3, 2022

Conversation

ckormanyos
Copy link
Owner

This PR makes wide-integer's internal algorithms compatible with bidirectional -iterators (and not just random-access-iterators). This may be useful for future design steps.

@ckormanyos
Copy link
Owner Author

See also some discussion regarding this point in #91

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #322 (e5dc6d1) into master (ec8e21a) will decrease coverage by 0.3%.
The diff coverage is 97.5%.

❗ Current head e5dc6d1 differs from pull request most recent head 227d327. Consider uploading reports for the commit 227d327 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #322     +/-   ##
========================================
- Coverage   100.0%   99.8%   -0.2%     
========================================
  Files          36      36             
  Lines        3178    3141     -37     
========================================
- Hits         3178    3132     -46     
- Misses          0       9      +9     
Impacted Files Coverage Δ
examples/example008_miller_rabin_prime.cpp 100.0% <ø> (ø)
examples/example008a_miller_rabin_prime.cpp 100.0% <ø> (ø)
test/test_uintwide_t_examples.cpp 100.0% <ø> (ø)
math/wide_integer/uintwide_t.h 99.4% <97.0%> (-0.6%) ⬇️
test/test.cpp 100.0% <100.0%> (ø)
test/test_uintwide_t_edge_cases.cpp 100.0% <100.0%> (ø)
test/test_uintwide_t_spot_values.cpp 99.7% <100.0%> (-0.3%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8e21a...227d327. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@ckormanyos ckormanyos merged commit 19a236c into master Oct 3, 2022
@ckormanyos ckormanyos deleted the try_refactor_distances branch October 3, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant