Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New linking experience. #17368

Draft
wants to merge 112 commits into
base: master
Choose a base branch
from
Draft

New linking experience. #17368

wants to merge 112 commits into from

Commits on Oct 15, 2024

  1. Feature (link): Update UI of the small Link panel

    @filipsobol
    filipsobol committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    da30dbd View commit details
    Browse the repository at this point in the history

  2. Optimize SVG

    @filipsobol
    filipsobol committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1b3d161 View commit details
    Browse the repository at this point in the history

  3. Make the existing tests pass

    @filipsobol
    filipsobol committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    56df972 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Rename left and right o leftSlot and rightSlot

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7e317cc View commit details
    Browse the repository at this point in the history

  2. Remove unfinished code for displaying errors for the "Displayed text"… 

    … input, as it won't have any validation
    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    66c2305 View commit details
    Browse the repository at this point in the history

  3. Add tests covering leftSlot and rightSlot

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bc9cb31 View commit details
    Browse the repository at this point in the history

  4. Make the "Insert" button slightly wider, as per the design

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6141b0f View commit details
    Browse the repository at this point in the history

  5. Add missing code comments

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    65b7116 View commit details
    Browse the repository at this point in the history

  6. Update based on feedback

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    35b6de5 View commit details
    Browse the repository at this point in the history

  7. Revert change in resetFormStatus

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    15697ab View commit details
    Browse the repository at this point in the history

  8. Update checked class name

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bacbfa7 View commit details
    Browse the repository at this point in the history

  9. Fix test

    @filipsobol
    filipsobol committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6888409 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Use form view is link UI footer

    @filipsobol
    filipsobol committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    164a78b View commit details
    Browse the repository at this point in the history

  2. Add missing dev dependency

    @filipsobol
    filipsobol committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d8cfa76 View commit details
    Browse the repository at this point in the history

  3. Fix dependency version

    @filipsobol
    filipsobol committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a82849f View commit details
    Browse the repository at this point in the history

  4. Replaced LinkActionsView with ToolbarView.

    @niegowski
    niegowski committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6a17c14 View commit details
    Browse the repository at this point in the history

  5. Updated theme css.

    @niegowski
    niegowski committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a5054d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Add missing items to the contexts.json

    @filipsobol
    filipsobol committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9eae802 View commit details
    Browse the repository at this point in the history

  2. Replaced bookmark actions view with bookmark toolbar.

    @niegowski
    niegowski committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    926d12d View commit details
    Browse the repository at this point in the history

  3. Added missing theme changes.

    @niegowski
    niegowski committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b2b8382 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/ck/epic/17230-linking-experience' into ck/17… 

    …230-link-toolbar
    @niegowski
    niegowski committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2fd1097 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Kuba Niegowski <[email protected]>
Co-authored-by: Piotr Szczęśniak <[email protected]>
    @filipsobol @niegowski @pszczesniak
    3 people authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8801976 View commit details
    Browse the repository at this point in the history

  2. Update name of the variable

    @filipsobol
    filipsobol committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e5c3ba9 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #17265 from ckeditor/update-small-link-panel 

    Feature (core): Add `settings` icon. See #17230.

Feature (link): Update UI of the small Link panel. See #17230.
    @filipsobol
    filipsobol authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fc52947 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/ck/epic/17230-linking-experience' into ck/17… 

    …230-link-toolbar

# Conflicts:
#	packages/ckeditor5-link/src/linkui.ts
    @niegowski
    niegowski committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    21284d2 View commit details
    Browse the repository at this point in the history

  5. Simplified handling of scroll to bookmark.

    @niegowski
    niegowski committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c06c42d View commit details
    Browse the repository at this point in the history

  6. Feature (link): Add Advanced view UI

    @filipsobol
    filipsobol committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4273091 View commit details
    Browse the repository at this point in the history

  7. Added tests for custom positions for widget toolbar.

    @niegowski
    niegowski committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bdb872b View commit details
    Browse the repository at this point in the history

  8. Updated tests for BookmarkUI.

    @niegowski
    niegowski committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3600a2d View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Added tests.

    @niegowski
    niegowski committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8c42492 View commit details
    Browse the repository at this point in the history

  2. Adding tests.

    @niegowski
    niegowski committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3e3f343 View commit details
    Browse the repository at this point in the history

  3. Feature (link): Properly handle opening and closing of the Advanced p… 

    …anel and changing the value of link decorators.
    @filipsobol
    filipsobol committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0f1c3c1 View commit details
    Browse the repository at this point in the history

  4. Adding tests.

    @niegowski
    niegowski committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ad799cf View commit details
    Browse the repository at this point in the history

  5. Destroy the Advanced view together with the rest of views and add mis… 

    …sing comment.
    @filipsobol
    filipsobol committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6a72381 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Added bookmarks view panel.

    @pszczesniak
    pszczesniak committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d714014 View commit details
    Browse the repository at this point in the history

  2. Show message when no bookmarks available.

    @pszczesniak
    pszczesniak committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d96fd2c View commit details
    Browse the repository at this point in the history

  3. Do not auto-update decorators

    @filipsobol
    filipsobol committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1d05aa5 View commit details
    Browse the repository at this point in the history

  4. Include link toolbar in toolbars cycling.

    @niegowski
    niegowski committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    42b2795 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Style the empty information when no bookmarks available. 

    Signed-off-by: Piotr Szczęśniak <[email protected]>
    @pszczesniak
    pszczesniak committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2ec5eae View commit details
    Browse the repository at this point in the history

  2. Removed commented code.

    @pszczesniak
    pszczesniak committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7abf7b8 View commit details
    Browse the repository at this point in the history

  3. Code refactor.

    @niegowski
    niegowski committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    23109ae View commit details
    Browse the repository at this point in the history

  4. Code refactor.

    @pszczesniak
    pszczesniak committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7b3f6cb View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @filipsobol
    filipsobol committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bcf7e7e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Fix the widths of input fields.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    edd58fd View commit details
    Browse the repository at this point in the history

  2. Added comments to explain how to manage the focus.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cec3747 View commit details
    Browse the repository at this point in the history

  3. Moved bookmark icons to the core package.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1677b46 View commit details
    Browse the repository at this point in the history

  4. Added bookmark icon to the bookmark list item.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ebf370c View commit details
    Browse the repository at this point in the history

  5. Fix code coverage

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f86ac7b View commit details
    Browse the repository at this point in the history

  6. Add translations

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d286299 View commit details
    Browse the repository at this point in the history

  7. Remove comment

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    55faede View commit details
    Browse the repository at this point in the history

  8. Remove comment

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7941da9 View commit details
    Browse the repository at this point in the history

  9. Fix comment

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c9b6418 View commit details
    Browse the repository at this point in the history

  10. Fix comments

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b70797f View commit details
    Browse the repository at this point in the history

  11. Added tests to 'getAllBookmarkNames' method.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    77ddc30 View commit details
    Browse the repository at this point in the history

  12. Code refactor.

    @niegowski
    niegowski committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    aa52358 View commit details
    Browse the repository at this point in the history

  13. Added tests.

    @pszczesniak
    pszczesniak committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b3a8095 View commit details
    Browse the repository at this point in the history

  14. Move common translations to the core package

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    02788fb View commit details
    Browse the repository at this point in the history

  15. Remove the showAdvanced event and use generic execute event instead

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6b2a7ed View commit details
    Browse the repository at this point in the history

  16. Use div instead of form

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2572f59 View commit details
    Browse the repository at this point in the history

  17. Add dedicated advanced view class

    @filipsobol
    filipsobol committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1910f40 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Added event type.

    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8eef5f6 View commit details
    Browse the repository at this point in the history

  2. Change the order of removing views and update the isUIVisible getter.

    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f241f43 View commit details
    Browse the repository at this point in the history

  3. Added tests for LinkUI class.

    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f54ba36 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2f2b5d1 View commit details
    Browse the repository at this point in the history

  5. Feedback fixes

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    00dd241 View commit details
    Browse the repository at this point in the history

  6. Reuse available method

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    40a9239 View commit details
    Browse the repository at this point in the history

  7. Fix test

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    239f33f View commit details
    Browse the repository at this point in the history

  8. Apply suggestions.

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    80fbb3c View commit details
    Browse the repository at this point in the history

  9. Change default values in test

    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2edffb6 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #17325 from ckeditor/add-advanced-view-to-link-ui 

    Feature (link): Add the Advanced panel with link decorators to the link UI. See #17230.
    @filipsobol
    filipsobol authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5f1c8e6 View commit details
    Browse the repository at this point in the history

  11. Updated tests.

    @niegowski
    niegowski committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ac62819 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'refs/heads/ck/epic/17230-linking-experience' into ck/17… 

    …230-link-toolbar
    @niegowski
    niegowski committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    512bd73 View commit details
    Browse the repository at this point in the history

  13. Other (link): Hide the settings button if there are no manual decorat… 

    …ors.
    @filipsobol
    filipsobol committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1a3c069 View commit details
    Browse the repository at this point in the history

  14. Added more tests.

    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6eed8f4 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'ck/epic/17230-linking-experience' into ck/17230-bookmar… 

    …ks-view.
    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2dd03ad View commit details
    Browse the repository at this point in the history

  16. Styled bookmarks panel.

    @pszczesniak
    pszczesniak committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea8ec24 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Piotr Szczęśniak <[email protected]>
    @filipsobol @pszczesniak
    filipsobol and pszczesniak authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0d3ba80 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review.

    @pszczesniak
    pszczesniak committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b0eaeab View commit details
    Browse the repository at this point in the history

  3. Merge pull request #17347 from ckeditor/hide-settings-button-without-… 

    …decorators

Other (link): Hide the settings button if there are no manual decorators. See #17230
    @filipsobol
    filipsobol authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b114b7c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into ck/epic/17230-linki… 

    …ng-experience
    @filipsobol
    filipsobol committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    6c5857f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'refs/heads/ck/epic/17230-linking-experience' into ck/17… 

    …230-bookmarks-view

# Conflicts:
#	packages/ckeditor5-bookmark/src/bookmarkediting.ts
    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    17e1a9c View commit details
    Browse the repository at this point in the history

  6. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    da427fa View commit details
    Browse the repository at this point in the history

  7. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7b756cb View commit details
    Browse the repository at this point in the history

  8. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b42a230 View commit details
    Browse the repository at this point in the history

  9. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8094374 View commit details
    Browse the repository at this point in the history

  10. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    77aa258 View commit details
    Browse the repository at this point in the history

  11. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8ab51c9 View commit details
    Browse the repository at this point in the history

  12. Code refactor.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b603e81 View commit details
    Browse the repository at this point in the history

  13. Added missing context.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2127878 View commit details
    Browse the repository at this point in the history

  14. Fixed tests.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    327a8ca View commit details
    Browse the repository at this point in the history

  15. Merge pull request #17340 from ckeditor/ck/17230-bookmarks-view 

    Feature (link): Add the Bookmarks panel to the link UI. See #17230.
    @niegowski
    niegowski authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a6e5dd6 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'refs/heads/ck/epic/17230-linking-experience' into ck/17… 

    …230-link-toolbar
    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    10ea525 View commit details
    Browse the repository at this point in the history

  17. Fix imports.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9bba842 View commit details
    Browse the repository at this point in the history

  18. Added tests.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8681829 View commit details
    Browse the repository at this point in the history

  19. Added tests.

    @niegowski
    niegowski committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d2a706e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Fixed dependencies.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7312f71 View commit details
    Browse the repository at this point in the history

  2. Added bookmark icon on link preview button.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3507e74 View commit details
    Browse the repository at this point in the history

  3. Updated tests.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ab4e356 View commit details
    Browse the repository at this point in the history

  4. Code cleanup before review.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4eef8e6 View commit details
    Browse the repository at this point in the history

  5. Other (link): Rename the cancel event to back in LinkAdvancedView.

    @filipsobol
    filipsobol committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9e577ed View commit details
    Browse the repository at this point in the history

  6. Renamed internal method.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4a59575 View commit details
    Browse the repository at this point in the history

  7. Docs fixes.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c698b4a View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @filipsobol
    filipsobol committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0bec17a View commit details
    Browse the repository at this point in the history

  9. Updated styles.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4a23fde View commit details
    Browse the repository at this point in the history

  10. Fix docs.

    @niegowski
    niegowski committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    680aa2f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge pull request #17364 from ckeditor/rename-the-cancel-event-to-back 

    Other (link): Rename the `cancel` event to `back` in `LinkAdvancedView`. See  #17230.
    @filipsobol
    filipsobol authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1928ac6 View commit details
    Browse the repository at this point in the history

  2. Updated bookmark icons.

    @niegowski
    niegowski committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    32baeb8 View commit details
    Browse the repository at this point in the history

  3. Added missing icons.

    @niegowski
    niegowski committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    235023b View commit details
    Browse the repository at this point in the history

  4. Updated optimized icon.

    @niegowski
    niegowski committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5104e6b View commit details
    Browse the repository at this point in the history

  5. Removed redundant css class.

    @niegowski
    niegowski committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1f1e736 View commit details
    Browse the repository at this point in the history

  6. Changed bookmark icon sizes to be relative to the main font size.

    @pszczesniak
    pszczesniak committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    610d412 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #17283 from ckeditor/ck/17230-link-toolbar 

    Other (link): The Link feature now uses the ToolbarView instead of a custom LinkActionsView to display the link toolbar in the contextual balloon. The new toolbar uses components registered in the ComponentFactory.

Other (bookmark): The Bookmark feature now uses the WidgetToolbarRepository instead of a custom ActionsView to display the bookmark toolbar in the contextual balloon. The new toolbar uses components registered in the ComponentFactory.

Fix (ui): The ButtonView#icon property can now be set/reset after the button's first render.

Other (ui): The IconView now throws a meaningful error if the provided icon content is not a valid SVG.

Other (widget): The WidgetToolbarRepository#register() now accepts a customized list of desired balloon positions.

BREAKING CHANGE (link): The LinkUI#actionsView is no longer available. The bookmark feature now uses the LinkUI#toolbarView (an instance of the ToolbarView class) instead of the custom LinkActionsView.

BREAKING CHANGE (bookmark): The BookmarkUI#actionsView is no longer available. The Bookmark feature is now using the WidgetToolbarRepository instead.

MINOR BREAKING CHANGE (link): The createBookmarkCallbacks() helper is now replaced by the isScrollableToTarget() and scrollToTarget() helpers.
    @niegowski
    niegowski authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d53fa3d View commit details
    Browse the repository at this point in the history