New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Avoid global state to improve icons tree-shaking. #17345

Merged

filipsobol merged 1 commit into master from fix-treeshaking-of-icons

Oct 28, 2024

Member

filipsobol commented Oct 28, 2024 •

edited

Loading

Suggested merge commit message (convention)

Fix (bookmarks): Avoid global state to improve icons tree-shaking.

Two global variables in the new bookmarks plugin prevented the icons object from the core package from being properly tree-shaken.


          Fix: Avoid global state to improve icons tree-shaking.

c59c9c2

filipsobol requested a review from pszczesniak

October 28, 2024 12:24

pszczesniak approved these changes

View reviewed changes

filipsobol merged commit 49edd01 into master

10 checks passed

filipsobol deleted the fix-treeshaking-of-icons branch

October 28, 2024 12:58

filipsobol mentioned this pull request

Add the Bookmarks panel to the link UI. #17340

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet