No longer jump to the first item after replacing phrase

[Mati365]

Suggested merge commit message (convention)

Fix (find-and-replace): Find and replace no longer randomly jumps to the first found item after the replace operation. Closes #16648

---

Additional information

After removal of marker, we used to reset search to the first changed item. It's buggy because changed items refer to search results affected by the update algorithm, which used to change found elements, even if they were not replaced. It caused "random" jumps between items after replace.

The example might be this list of results:

I replaced one word in a paragraph containing few search results with 2, 3 and 4 indices. It updated item with 3 index, but it turns out that algorithm updated also items with 2 i 4 IDs. It's counterintuitive, and leaded to the incorrect assumption in the editing flow that we can reset to the first changed node when at least one yellow marker above the search result is removed. In this case, highlight item was pointed to 2 item instead of 4 item.

I enforced restoring old highlight offset after operations, so it should be fine now.

Before

find-and-replace-before-2024-10-22_07.28.59.mp4

After

find-and-replace-after-2024-10-22_07.26.36.mp4

[Mati365]

@charlttsie Can you take a look and perform a QA check on this change?

[juliaflejterska]

Find and replace jumps to incorrect item in multi-root editor

Steps

1. Open the multi-root editor with multiple roots containing paragraphs with several replaceable items.
2. Use Find and replace feature to replace the 2nd item in the 1st root.

Result

After replacing the 2nd item in the 1st root, Find and replace jumps to the 2nd root and replaces the 2nd item:

multiroot.mov

[Mati365]

I pushed some changes, it turns out that results were not sorted correctly regarding multi root's order and were misaligned in state. Nice finding @juliaflejterska!

[charlttsie]

We've finished testing the PR with @juliaflejterska, and it looks good to us. The initial issue is fixed, and we haven't found any regressions other than the issue with the multi-root editor, which no longer occurs after the recent changes 👍