Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark feature #17278

Merged
merged 305 commits into from
Oct 24, 2024
Merged

Bookmark feature #17278

merged 305 commits into from
Oct 24, 2024

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented Oct 17, 2024

Suggested merge commit message (convention)

Feature (bookmark): Introduces the bookmark feature. Closes #1944.

Fix (list): Inserting or dropping a paragraph after the end of a list should not convert the paragraph to a list item. Closes #17224.


Additional information

@pszczesniak pszczesniak marked this pull request as ready for review October 24, 2024 08:04
Copy link
Contributor

@godai78 godai78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM.


## Documentation

See the {@link features/bookmarks bookmarks feature guide} and the {@link module:block-quote/blockquote~BlockQuote} plugin documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@godai78  Is the plugin documentation link correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was updated recently.

@arkflpc arkflpc merged commit 21c6f46 into master Oct 24, 2024
9 checks passed
@arkflpc arkflpc deleted the ck/epic/1944-bookmark branch October 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants