Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: restoring X in demos. #17276

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Docs: restoring X in demos. #17276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/ckeditor5-media-embed/docs/_snippets/features/media-embed-preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<div class="ck ck-content" id="snippet-media-embed-preview">
<h3>Follow us on X for the latest news:</h3>
<figure class="media">
<oembed url="https://x.com/ckeditor/status/1441013225554948096"></oembed>
</figure>
<h3>And check our latest posts on Facebook:</h3>
<figure class="media">
<oembed
Expand Down
6 changes: 6 additions & 0 deletions packages/ckeditor5-media-embed/docs/_snippets/features/media-embed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ <h3>Vimeo</h3>
<oembed url="https://vimeo.com/1084537"></oembed>
</figure>

<h3>X (form. Twitter)</h3>

<figure>
<oembed url="https://x.com/ckeditor/status/1430561610494627841"></oembed>
</figure>

<h3>Google Maps</h3>

<figure class="media">
Expand Down
12 changes: 6 additions & 6 deletions packages/ckeditor5-media-embed/docs/features/media-embed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Optionally, by setting `mediaEmbed.previewsInData` to `true` you can configure t
</figure>
```

Currently, the preview is only available for content providers for which CKEditor&nbsp;5 can predict the `<iframe>` code: YouTube, Vimeo, Dailymotion, Spotify, etc. For other providers like Twitter (X) or Instagram, the editor cannot produce an `<iframe>` code. It also does not allow retrieving this code from an external oEmbed service. Therefore, for non-previewable media, it produces the default semantic output:
Currently, the preview is only available for content providers for which CKEditor&nbsp;5 can predict the `<iframe>` code: YouTube, Vimeo, Dailymotion, Spotify, etc. For other providers like X (Twitter) or Instagram, the editor cannot produce an `<iframe>` code. It also does not allow retrieving this code from an external oEmbed service. Therefore, for non-previewable media, it produces the default semantic output:

```html
<figure class="media">
Expand Down Expand Up @@ -250,11 +250,11 @@ First, having [secured the API key](https://iframely.com/docs/allow-origins), lo

#### Semantic data

You can convert all `<oembed>` elements like the following Twitter (X) post produced by CKEditor&nbsp;5:
You can convert all `<oembed>` elements like the following X (Twitter) post produced by CKEditor&nbsp;5:

```html
<figure class="media">
<oembed url="https://twitter.com/ckeditor/status/1021777799844126720"></oembed>
<oembed url="https://x.com/ckeditor/status/1021777799844126720"></oembed>
</figure>
```

Expand All @@ -274,7 +274,7 @@ When you configure the feature to [include media previews](#including-previews-i

```html
<figure class="media">
<div data-oembed-url="https://twitter.com/ckeditor/status/1021777799844126720">
<div data-oembed-url="https://x.com/ckeditor/status/1021777799844126720">
[Media preview]
</div>
</figure>
Expand Down Expand Up @@ -316,7 +316,7 @@ You can convert `<oembed>` elements like the following Twitter (X) post produced

```html
<figure class="media">
<oembed url="https://twitter.com/ckeditor/status/1021777799844126720"></oembed>
<oembed url="https://x.com/ckeditor/status/1021777799844126720"></oembed>
</figure>
```

Expand Down Expand Up @@ -377,7 +377,7 @@ If the automatic embedding was unexpected, for instance when the link was meant

## Styling media in the editor content

While the editor comes with default styles for popular media providers like Facebook, Instagram or Twitter, you can create additional styles for non-previewable media in your editor content to help users identify them.
While the editor comes with default styles for popular media providers like Facebook, Instagram or X, you can create additional styles for non-previewable media in your editor content to help users identify them.

### Styling non-previewable media

Expand Down