Redesign CDN deploy to upload to a tagged version #17240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martnpaneq
reviewed
Oct 9, 2024
| { | ||
| title: 'Checking if packages that returned E409 error code were uploaded correctly.', | ||
| task: async ( _, task ) => { | ||
| return releaseTools.verifyPackagesPublishedCorrectly( { |
There was a problem hiding this comment.
What about this check? Are we not going to check for 409 errors any more?
There was a problem hiding this comment.
Review ckeditor/ckeditor5-dev#1019, please.
LukaszGudel
previously approved these changes
Oct 10, 2024
martnpaneq
previously approved these changes
Oct 10, 2024
…ould be a number instead of a tag.
pomek
dismissed stale reviews from martnpaneq, LukaszGudel, and psmyrek
via
430a806
LukaszGudel
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: While uploading CDN files, they target a tagged directory instead of an
X.Y.Zversion. In case of a stable (staging) release, the rename will be performed later in the release process, allowing us to restart the entire process without affecting users using CDN.Additional information