Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed for linking FocusTracker instances together and propagate the focus state #17206

Merged
merged 12 commits into from
Oct 22, 2024

Conversation

oleq
Copy link
Member

@oleq oleq commented Oct 2, 2024

Suggested merge commit message (convention)

Fix (ui): The dropdown menu component should not cause an editor blur if used in a BalloonToolbar while the user hovers a nested menu. Closes #17277.

Feature (utils): Made FocusTracker extendable with other FocusTracker instances to allow logical focus tracking across separate DOM sub-trees.


Additional information

Closes https://github.com/cksource/ckeditor5-commercial/issues/6633.

Comes with https://github.com/cksource/ckeditor5-commercial/pull/6672

TODOs:

@oleq oleq changed the title Allowed for linking FocusTracker instances together and propagate the focus state. Allowed for linking FocusTracker instances together and propagate the focus state Oct 3, 2024
scofalik
scofalik previously approved these changes Oct 16, 2024
Copy link
Contributor

@scofalik scofalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that full and deep code review would take a lot of my time, trying to get to the roots of how exactly this work.

I added some comments to places which weren't immediately obvious to me, but after going through it for the second time, I think I understood why they are like that. It seems to me that introduced changes make sense.

But I cannot tell whether something is missing, or some other place should be modified too.

I know you put a lot of (hehe) focus into this issue and this is a third (?) try to get it working in a way that won't introduce breaking changes. So I think I have to lean on your experience in this matter.

Happy to talk about the bits which I commented on, I wonder if I got it right.

packages/ckeditor5-utils/src/focustracker.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/focustracker.ts Show resolved Hide resolved
@oleq oleq requested a review from scofalik October 17, 2024 15:07
@DawidKossowski DawidKossowski marked this pull request as ready for review October 21, 2024 14:48
Copy link
Contributor

@scofalik scofalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please finish the todos and the one thing regarding the private member, and it should be fine.

packages/ckeditor5-utils/src/focustracker.ts Show resolved Hide resolved
@oleq oleq merged commit 8ca7301 into master Oct 22, 2024
10 checks passed
@oleq oleq deleted the cc/6633-v2a branch October 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AiCommands in balloonToolbar not selectable
2 participants