Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Microsoft Narrator tables PoC #17083

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 12, 2024

Suggested merge commit message (convention)

Add basic PoC that fixes 0 by 0 Microsoft Narrator screen reader


Additional information

This PR tests changing this cell HTML structure:

<th colspan="2" rowspan="4" class="ck-table-cell-content ck-editor__editable ck-editor__nested-editable" role="textbox" tabindex="-1" contenteditable="true">
    <span class="ck-table-bogus-paragraph">Terrestrial planets</span>
</th>

to:

<th colspan="2" rowspan="4">
  <div class="ck-table-cell-content ck-editor__editable ck-editor__nested-editable" role="textbox" tabindex="-1" contenteditable="true">
    <span class="ck-table-bogus-paragraph">Terrestrial planets</span>
  </div>
</th>

Table behavior is buggy, but narrator works correctly.

Observations

  1. It's super laggy on Firefox with Grammarly plugin, focusing single table cell takes ~1s. It does not happen in incognito mode.
  2. Most of the table cell editable CSS is broken. Making contenteditable cell content height to fill entire cell is problematic on Firefox as it's centered (on Chrome it works fine)
    obraz
  3. It looks like selection of the table is buggy and sometimes, mostly during selection, it selects neighbor table cells text content.
  4. Some plugins depend on td content and do not expect that the first child is content wrapper (e.g. table column resize plugin). These plugins need to be adjusted and tested.
  5. Fast selection change causes infinity hang on Edge
    obraz

@Mati365 Mati365 changed the title Add basic PoC Add basic Microsoft Narrator tables PoC Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant