Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor name - if init target has ID, use ID as editor name. #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

Editor name - if init target has ID, use ID as editor name. #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ckeditor/ckeditor.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,13 @@ export class CKEditorComponent implements AfterViewInit, OnDestroy, ControlValue

private createEditor(): void {
const element = document.createElement( this.tagName );
const elementId = this.elementRef.nativeElement.id;

// if the user has specified an id on the node in which they're initializing on, use that ID as the name of the editor!
if ( elementId ) {
element.id = elementId;
}

this.elementRef.nativeElement.appendChild( element );

const userInstanceReadyCallback = this.config?.on?.instanceReady;
Expand Down