(feature): option to record videos. #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this already working? |
|
This currently has two issues. For some reason on line 224 and 225 of main.ts the lines actually starting the script are removed, making the resource completely unusable, and on client.ts it sends the original "options" array instead of a new object to the UI, the ui fails to convert the file to a ScreenshotRequest object. I have submitted a pull request for both of these, and it seems to work great with both of these issues fixed! |
Add the record feature, which allows for a more "developed" capturing of a client's game.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the record feature, which allows for a more "enhanced" capturing of a client's game.