Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extra-natives/five): GetVehicleDashboardCurrentGear #2914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tens0rfl0w
Copy link
Contributor

Goal of this PR

"VehicleDashboardData" doesn't contain the water temperature as a metric. This corrects the struc to represent the real value (currentGear).

How is this PR achieving the goal

Correcting the struc and native naming.

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3258

Platforms: Windows (Client)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

/

"VehicleDashboardData" doesn't contain water temperature as a metric. This corrects the struc to represent the real value (currentGear).
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Nov 7, 2024
Copy link
Contributor

@Nobelium-cfx Nobelium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this!

Tested locally. Seems to work as intended.

@Nobelium-cfx Nobelium-cfx added the ready-to-merge This PR is enqueued for merging label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants