fix(server): don't invoke cfx_internal:serverPrint on empty string #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to send the client "nothing" as data, so we discard it.
github-actions
bot
added
the
invalid
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This resolves the reported issue of blank lines cluttering the client console output.
How is this PR achieving the goal
Discarding empty data previously sent to the client, preventing unnecessary "empty line" entries from appearing in the client console.
This PR applies to the following area(s)
Server
Successfully tested on
Game builds: Not applicable
Platforms: Windows
Checklist
Fixes issues
/