Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voip-mumble): nullptr check #2897

Merged

Conversation

tens0rfl0w
Copy link
Contributor

@tens0rfl0w tens0rfl0w commented Oct 31, 2024

Goal of this PR

This fixes a nullptr exception when trying to write to the Audio Processing Module while the audioCaptureClient is invalid.

We now also apply the last voice intent mode to the new audio device instead of the default ('speech') mode.

How is this PR achieving the goal

Added a nullptr check before trying to write to the Audio Processing Module.

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: Not applicable

Platforms: Windows (Client)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Reported here: https://discord.com/channels/779705925577080842/1301532596240515082 (Cfx.re Engineering Group)

This fixes a nullptr exception when trying to write to the Audio Processing Module while the audioCaptureClient is invalid.

We now also apply the last voice intent mode to the new audio device instead of the default ('speech') mode.
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Oct 31, 2024
@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Nov 5, 2024
@prikolium-cfx prikolium-cfx merged commit be33c7f into citizenfx:master Nov 5, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants