fix(server/state): properly reassign entities that are set to EntityOrphanMode::KeepEntity
#2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OrphanMode::KeepEntity` - this swaps `MoveEntityToCanidate` to use `ShouldServerKeepEntity` instead of having specific logic for orphan mode - makes 'entitiesToDestroy' use `ShouldServerKeepEntity` instead of `IsOwnedByServerScript`so we reassign if orphan mode is set to keep the entity
github-actions
bot
added
the
invalid
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MoveEntityToCanidateto useShouldServerKeepEntityinstead of having specific logic for orphan modeShouldServerKeepEntityinstead ofIsOwnedByServerScriptso we reassign if orphan mode is set to keep the entityGoal of this PR
Properly reassign the entity to the server in certain situations where it would previously not happen
How is this PR achieving the goal
Add a new function that uses the original script check & entity orphan checks
This PR applies to the following area(s)
Server
Successfully tested on
Platforms: Windows
Checklist