tweak(codegen): set VAR_STRING as an unsupported type for OAL #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this makes the native usable in OAL, even if it will use a slower path.
github-actions
bot
added
RedM
|
didnt know that list existed. thanks for this |
Yes, it'll fallback to the normal NativeInvoke. |
|
yes thanks, I read the description wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Allow
VAR_STRINGto be used on RDR when using OALHow is this PR achieving the goal
Marks it as 'unsupported' so it wont be generated as a supported native for OAL
This PR applies to the following area(s)
RedM
Successfully tested on
This was only tested that it doesn't add to the map in
NativesRDR.hGame builds: ..
Platforms: Windows, Linux
Checklist
Fixes issues
Fixes the issue @outsider31000 reported