Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tool/formats): five -> rdr3 embedded textures crash on unload #2321

Merged
merged 2 commits into from
May 28, 2024
Merged

fix(tool/formats): five -> rdr3 embedded textures crash on unload #2321

merged 2 commits into from
May 28, 2024

Conversation

Ktos93
Copy link
Contributor

@Ktos93 Ktos93 commented Dec 31, 2023

Goal of this PR

Fix crash when models with embedded textures crash on unload

This PR applies to the following area(s)

RedM converter

Successfully tested on

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@Disquse Disquse self-assigned this Jan 2, 2024
Disquse
Disquse approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Disquse Disquse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as intended, thanks.

RedM_b1491_GTAProcess_WNI0mqb92B.mp4

@Disquse Disquse added the ready-to-merge This PR is enqueued for merging label May 27, 2024
@prikolium-cfx prikolium-cfx merged commit 9e7d797 into citizenfx:master May 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disquse Disquse Disquse approved these changes

Assignees

@Disquse Disquse

Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ktos93 @Disquse @prikolium-cfx