trex_astf_client: use proper to_json_str call #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The profile object returned from ASTFProfile.load can be of type ASTFProfileLight if the passed "profile" is a path to a json profile file. ASTFProfileLight has a different to_json_str signature, and calling the method assuming the returned profile object is of type ASTFProfile will lead to failures in this case. Signed-off-by: bzalkilani <[email protected]>
|
Checked SHA: 909fec4 |
|
@hhaim can you please help me figure out why the CI fails so I can fix it? |
|
@bzalkilani it seems as our issue. |
|
recheck |
|
Checked SHA: 909fec4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profile object returned from ASTFProfile.load
can be of type ASTFProfileLight if the passed
"profile" is a path to a json profile file.
ASTFProfileLight has a different to_json_str
signature, and calling the method assuming
the returned profile object is of type
ASTFProfile will lead to failures in this
case.