Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests to be ran in the pipeline, add documentation #16

Closed
wants to merge 2 commits into from

Conversation

DodinViorel
Copy link
Contributor

Description

Minor fixes, enabled tests, added more comprehensive documentation

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@DodinViorel
Copy link
Contributor Author

Acceptance tests do not pass on github due to lack of network connectivity without a VPN. Waiting for new tenant on which the tests will provision infrastructure where access is public.

DodinViorel added a commit to DodinViorel/terraform-provider-observability that referenced this pull request May 7, 2024
DodinViorel added a commit to DodinViorel/terraform-provider-observability that referenced this pull request May 7, 2024
DodinViorel added a commit to DodinViorel/terraform-provider-observability that referenced this pull request May 7, 2024
kprav33n pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Viorel Dodin <[email protected]>
@DodinViorel
Copy link
Contributor Author

Temporary solution is to not run acceptance tests as part of github actions, only unit tests

@bogdanguranda
Copy link
Contributor

bogdanguranda commented May 8, 2024

@DodinViorel I copied over all of your changes to my own fork PR (in addition to my changes): #21

You can safely close this PR.

@DodinViorel DodinViorel closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants