Detect Intentional Input Binding for PTT #609
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of active bindings must be no more than two so that users do not inadvertently switch radios when a neighbouring hat switch is toggled for a brief millisecond.
This is an implementation as per the algorithm suggested in issue: #272
However, this PR would not resolve the illustrated scenario keybindings as the modifier would be superseded through the logic of the following lines:
DCS-SimpleRadioStandalone/DCS-SR-Client/Input/InputDeviceManager.cs
Lines 612 to 638 in e8b71ad
To resolve the original issue completely, it is suggested that the PTT, radio switching, and radio tuning should be elevated up to a state machine.
This PR would resolve my specific use case where the neighbouring hats are being triggered for a fraction which causes the radio to switch rapidly during transmission.