Differing Radio Powers #596
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored friis path loss down to single method Refactored to use transmission power rather than radio number Added initial framework for syncing radio and aircraft values between server and clients
Added Apache to aircraft and the associated radios Fixed incorrect values due to PRC not ARC documentation
Disable sending event on differing/custom radios set change Fixed outdated enum reference Functional proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per feature request #587.
The change to UDPVoicePacket is an additional byte in the frequency segment which expresses the Tx power of the sending radio.
Additionally the custom radio values mentioned in #587 are also working, allowing custom power/sensitivity for radios and which radio maps to which position in an aircraft. This adds two JSON config files, and changes to the NetworkMessage to include 2 new Dictionaries to transmit this info with a SYNC MessageType.
Server admins can choose to use differing radio powers or keep the previous system of all radios using the same values. If differing radio powers is enabled, they can also enable custom configurations which will then read from the JSON files.
One thing about the current implementation is that changes to radio power will only apply once the server is restarted.
Setting this to draft as it needs a quick clean up at this stage but I'd like to confirm the changes to MessageType, and that requiring a server restart to alter radio values won't be a problem. Also if you'd prefer this PR to be split into two parts, one for differing radio values and custom radio values that should be easy enough.