-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
69 fr extend set of available ansaetze #76
Conversation
…available-ansaetze
…vailable-ansaetze
…vailable-ansaetze
…ub.com/cirKITers/qml-essentials into 69-fr-extend-set-of-available-ansaetze
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work! 💪 I checked and found some discrepancy to the values provided in https://doi.org/10.1002/qute.201900070 .
We need to check what is going on there..
All circuits look good, thanks 🙏
General note: Circuit 10 deviates from the implementation because we build circuits layerwise which is not working with the proposed ansatz.
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Unable to fix the issue with discrepancy to the results in paper right now. Implementation of metrics looks fine and relative values behave as expected but absolute values deviate by up to 20% for expressibility and up to 50% for entangling capability to what is shown in the paper. Maybe @majafranz could have a look here?
|
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🔥
Closes #69
The last four commits, were caused because i saw some minor mistakes and used "Undo Last Commit" in VSCode after merging.