Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

69 fr extend set of available ansaetze #76

Merged
merged 36 commits into from
Jan 23, 2025

Conversation

paxuy
Copy link
Contributor

@paxuy paxuy commented Jan 14, 2025

Closes #69

The last four commits, were caused because i saw some minor mistakes and used "Undo Last Commit" in VSCode after merging.

@paxuy paxuy linked an issue Jan 14, 2025 that may be closed by this pull request
@pep8speaks
Copy link

pep8speaks commented Jan 14, 2025

Hello @paxuy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-23 09:54:25 UTC

@paxuy paxuy requested a review from stroblme January 15, 2025 09:39
Melvin Strobl added 3 commits January 15, 2025 14:43
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Copy link
Member

@stroblme stroblme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work! 💪 I checked and found some discrepancy to the values provided in https://doi.org/10.1002/qute.201900070 .
We need to check what is going on there..
All circuits look good, thanks 🙏
General note: Circuit 10 deviates from the implementation because we build circuits layerwise which is not working with the proposed ansatz.

Melvin Strobl added 10 commits January 16, 2025 10:04
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Melvin Strobl added 7 commits January 17, 2025 10:40
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme
Copy link
Member

Unable to fix the issue with discrepancy to the results in paper right now. Implementation of metrics looks fine and relative values behave as expected but absolute values deviate by up to 20% for expressibility and up to 50% for entangling capability to what is shown in the paper. Maybe @majafranz could have a look here?
To get this (temporarily) fixed, I adapted the tolerance to the deviation observed and removed all 3-layer expressibility tests (also to reduce the time it takes to run all tests).
Some observations:

  • the entangling capability for most circuits is underestimated by an factor of ~0.5.
  • higher expressive circuits (lower KL divergence) seem to be more prone to errors (up to 50% error) (numeric issues?)

Melvin Strobl added 2 commits January 17, 2025 11:14
Signed-off-by: Melvin Strobl <[email protected]>
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🔥

@stroblme stroblme self-requested a review January 23, 2025 10:23
@stroblme stroblme merged commit ba8b99e into main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Extend set of available Ansaetze
4 participants