Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PJAS-466 Tasks being enqueued multiple times during peak hours #1

Merged
merged 14 commits into from
Jul 11, 2024

Conversation

dgjorgjiev-prospective
Copy link
Contributor

@dgjorgjiev-prospective dgjorgjiev-prospective commented May 27, 2024

The issue seems to be related to the enqueue command during peak hours. It's possible the same task is being enqueued multiple times via boron because we never check if a task is already enqueued. This command takes place every minute, which means if the app is not able to process all the tasks within that minute, it will add them to the queue again. This will generate more retry attempts than specified.

Related PRs:
Boron: https://github.com/cineman/boron/pull/2
PJAS: https://github.com/prospective/pjas/pull/535

@dgjorgjiev-prospective
Copy link
Contributor Author

Breaking changes:

  • src/Driver/DriverInterface.php -> getStatsValue function now has mixed as return type.
  • src/Queue.php -> statsGetValue function now has mixed as return type.
  • src/ProcessManager.php -> setMaxWorkers function now has self as return type.
  • src/ProcessManager.php -> setIdleWait function now has self as return type.
  • src/ProcessManager.php -> work function now has void as return type.
  • src/Mutex.php -> safeExec function now has void as return type.
  • src/Mutex.php -> unlock function now has void as return type.
  • src/Mutex.php -> lock function now has void as return type.

@dgjorgjiev-prospective dgjorgjiev-prospective marked this pull request as ready for review June 27, 2024 08:30
@mario-deluna mario-deluna merged commit 367fe67 into master Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants