-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PJAS-466 Tasks being enqueued multiple times during peak hours #1
Merged
mario-deluna
merged 14 commits into
master
from
bugfix/PJAS-466-tasks-enqueue-multiple-times
Jul 11, 2024
Merged
PJAS-466 Tasks being enqueued multiple times during peak hours #1
mario-deluna
merged 14 commits into
master
from
bugfix/PJAS-466-tasks-enqueue-multiple-times
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in queue, apply phpcs fixes
Breaking changes:
|
mario-deluna
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue seems to be related to the enqueue command during peak hours. It's possible the same task is being enqueued multiple times via boron because we never check if a task is already enqueued. This command takes place every minute, which means if the app is not able to process all the tasks within that minute, it will add them to the queue again. This will generate more retry attempts than specified.
Related PRs:
Boron: https://github.com/cineman/boron/pull/2
PJAS: https://github.com/prospective/pjas/pull/535