FbBlobStream

[la-we]

Added FbBlobStream to be able to stream a blob from the database rather than having to fetch it completely. Especially useful when dealing with large BLOBs.

This is a working but possibly not clean solution. Have a look whether something should be cleaned up or improved.

[cincuranet]

Nice. Please give me some time to review it, as I'm currently busy.

[la-we]

Hey Jiri,

i have addressed your feedback in this updated commit! Thanks a lot for having an in-depth look at the changes!

[cincuranet]

@la-we Sorry for not taking another look sooner. I was busy with work and stuff. I'll do another pass in upcoming days.

[cincuranet]

In general looks good. Just some small nits.

[cincuranet]

Fix spaces in comment.

[fdcastel]

@la-we could you rebase with the latest master and work on the requested changes?

This would be a nice addition to the project.

[la-we]

@cincuranet Addressed your feedback. Sorry for the long waiting period...
@fdcastel Done!

[cincuranet]

@la-we Few pending comments left, mostly formatting. Otherwise LGTM and I'll merge after these are addressed.

[cincuranet]

@la-we Are you aware of the failing test?

1) Error : FirebirdSql.Data.FirebirdClient.Tests.BlobStreamTests(Embedded,False,Disabled).FbBlobStreamReadTest
FirebirdSql.Data.Common.IscException : invalid BLOB handle
   at FirebirdSql.Data.Client.Native.StatusVectorHelper.ProcessStatusVector(IntPtr[] statusVector, Charset charset, Action`1 warningMessage) in /_/src/FirebirdSql.Data.FirebirdClient/Client/Native/StatusVectorHelper.cs:line 39
   at FirebirdSql.Data.Client.Native.FesDatabase.ProcessStatusVector(IntPtr[] statusVector) in /_/src/FirebirdSql.Data.FirebirdClient/Client/Native/FesDatabase.cs:line 393
   at FirebirdSql.Data.Client.Native.FesBlob.CloseAsync(CancellationToken cancellationToken) in /_/src/FirebirdSql.Data.FirebirdClient/Client/Native/FesBlob.cs:line 433
   at FirebirdSql.Data.Common.BlobStream.DisposeAsync() in /_/src/FirebirdSql.Data.FirebirdClient/Common/BlobStream.cs:line 209
   at FirebirdSql.Data.FirebirdClient.Tests.BlobStreamTests.FbBlobStreamReadTest() in /_/src/FirebirdSql.Data.FirebirdClient.Tests/BlobStreamTests.cs:line 42
   at FirebirdSql.Data.FirebirdClient.Tests.BlobStreamTests.FbBlobStreamReadTest() in /_/src/FirebirdSql.Data.FirebirdClient.Tests/BlobStreamTests.cs:line 46
   at FirebirdSql.Data.FirebirdClient.Tests.BlobStreamTests.FbBlobStreamReadTest() in /_/src/FirebirdSql.Data.FirebirdClient.Tests/BlobStreamTests.cs:line 37
   at FirebirdSql.Data.FirebirdClient.Tests.BlobStreamTests.FbBlobStreamReadTest() in /_/src/FirebirdSql.Data.FirebirdClient.Tests/BlobStreamTests.cs:line 48

[la-we]

Nope, did not notice to be honest. I'll have a look at the failing tests

[la-we]

@cincuranet Tests are fixed!

[cincuranet]

Nice. I'll fix the #127 (comment) post merge. Thanks for your contribution!