Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating slimbar service to be Angular 6 compatible #1

Merged
merged 3 commits into from
Nov 7, 2018
Merged

updating slimbar service to be Angular 6 compatible #1

merged 3 commits into from
Nov 7, 2018

Conversation

cime
Copy link
Owner

@cime cime commented Nov 7, 2018

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adding package.json changes to follow up to PR: changed the reference to rxjs akserg/ng2-slim-loading-bar#68
  • What is the current behavior? (You can also link to an open issue here)
    angular6 support akserg/ng2-slim-loading-bar#67 - where the library is still referring the RxJs module under wrong location when updated to RxJs v6
  • What is the new behavior (if this is a feature change)?
    No behavior change except with testing 4 of the 16 test are not passing. Still trying to figure out why.
  • Other information:

@cime cime merged commit 39b3e50 into cime:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cime @inunotaisho