-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support constructed stylesheets in shadow DOM instances #3
Support constructed stylesheets in shadow DOM instances #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewortwein so far this looks good! Let me know when you're ready for QA and I'll give it a go there as well.
@andrewortwein Don't forget to generate a Changeset! |
@thafryer good point -- originally we were going to merge this PR and wait to do a proper release until my deduplicating-the-stylesheets work was in, but we've since decided the deduplicating work is not necessary right now. @andrewortwein as part of this we'll want to release the NPM package as well, let me know if you want to pair on that. |
Detect, serialize, and rebuild constructed stylesheets in shadow DOM elements.
QA
packages/rrweb-snapshot
yarn build
yarn link
to set this package up for local linking"@chromaui/rrweb-snapshot": "2.0.0-alpha.17"
with"@chromaui/rrweb-snapshot": "link:../../../rrweb/packages/rrweb-snapshot"
in each package.jsonyarn test:playwright && yarn archive-storybook:playwright
to launch the built Storybookstyles render in shadow DOM elements
andstyles render in web components in shadow DOM
stories properly display the color styles that are described by the text on those story pagesRepeat steps 5 & 6 for cypressI tried this but Cypress didn't seem to like the local link, so we will need to verify this after we publish a version of this package