Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Cypress archives in temp directory #38

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Put Cypress archives in temp directory #38

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36dcdd4
Blows away the chromatic-archives directory at the start of the test …
skitterm Nov 17, 2023
9dd4de3
Merge remote-tracking branch 'origin/main' into steven/fresh-chromati…
skitterm Nov 17, 2023
33c87b3
Merge remote-tracking branch 'origin/main' into steven/fresh-chromati…
skitterm Nov 17, 2023
fe259ab
Put archives in the Cypress-written downloads directory
skitterm Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cypress-api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ const doArchive = async ({
await writeTestResult(
{
title: testTitle,
// doesn't matter what value we put here, as long as it's a subdirectory of where we want this to actually go
// this will store it at ./cypress/downloads (the last directory doesn't matter)
// TODO: change so we don't have to do this trickery
outputDir: './some',
outputDir: './cypress/downloads/some',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird with this /some directory business in there (needed because we go back a directory in writeTestResult), but I'd like to tackle that later when we reuse code between Playwright and Cypress.

pageUrl,
},
allSnapshots,
Expand Down
Loading