Use non-forked rrweb #34
Conversation
tevanoff
force-pushed
the
rrweb-no-fork
branch
from
d1f4b0d to
2c9503f
Compare
tevanoff
force-pushed
the
rrweb-no-fork
branch
3 times, most recently
from
012ea55 to
486d853
Compare
tevanoff
changed the base branch from
todd/fix-css-attribute-mapping
to
main
tevanoff
force-pushed
the
rrweb-no-fork
branch
from
486d853 to
c2038b3
Compare
| "@segment/analytics-node": "^1.1.0", | ||
| "fs-extra": "^11.1.1", | ||
| "mime": "^3.0.0", | ||
| "rrweb-snapshot": "^2.0.0-alpha.4", |
There was a problem hiding this comment.
rrweb is up to like alpha.11, but alpha.4 is the one published as latest.
| @@ -30,8 +30,7 @@ export class ArchiveFile { | |||
| } | |||
|
|
|||
| originalSrc() { | |||
| // Assets that we capture will be stripped of the domain in the source | |||
| return `${this.url.pathname}${this.url.search}`; | |||
| return this.url.toString(); | |||
There was a problem hiding this comment.
This is the main change required after all of the previous asset mapping work. We're now expecting all asset paths to be full URLs since that's what rrweb does, so we don't strip off the protocol and origin here anymore.
| }, | ||
| }, | ||
| { | ||
| type: NodeType.Element, | ||
| attributes: { | ||
| src: '/img?src=some-path', | ||
| src: 'http://localhost:3000/img?src=some-path', |
There was a problem hiding this comment.
Do we save the URLs like this in the archives or as relative paths? If we save as absolutes, that would be a non-starter.
There was a problem hiding this comment.
The asset archive is built by watching network requests, so they are always the full URL there. This change makes it easier to match the assets from the archive with the attributes in the DOM since both sides will be full URLs now.
There was a problem hiding this comment.
Let me rephrase my question.
What happens when you render in the Capture Cloud? Do the archives try to pull from a relative path or http://localhost:3000? The localhost lookup will not work in the capture cloud so those need to be replaced by relative paths
There was a problem hiding this comment.
Ah yeah, they are relative in the archive storybook so that they load from the capture cloud. Otherwise all the images in the build would be broken!
| @@ -18,6 +18,7 @@ | |||
| <div><img src="/img?url=fixtures/pink.png"/></div> | |||
| <div><img src="/img"/></div> | |||
| <div><img src="/img/another"/></div> | |||
| <div><img src="relative/purple.png"/></div> | |||
There was a problem hiding this comment.
@thafryer added that relative path test for AP-3789
|
🚀 PR was released in |
Issue: CAP-1192
What Changed
Use standard, non-forked rrweb.
How to test
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.38--canary.34.22b8530.0✨ Test out this PR locally via: