-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR template standardized #201
Open
skitterm
wants to merge
9
commits into
main
Choose a base branch
from
steven/pr-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1184414
PR template standardized with changes to Chromatic PR template
skitterm aa6d368
Make sure we include changeset if releasing
skitterm ce6fff9
Actual link
skitterm b5c4023
Changeset, not checklist :facepalm
skitterm f0f769a
Whitespace removed
skitterm 4b060be
Require checkboxes to be, well, checked before merging
skitterm 4557c60
Read-all permissions for checklist check
skitterm bf4e3bc
Merge remote-tracking branch 'origin/main' into steven/pr-template
skitterm 6f92554
Comment-in the changeset section as we typically publish to NPM when …
skitterm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,33 @@ | ||
Issue: # | ||
|
||
## What Changed | ||
## Summary | ||
|
||
<!-- Insert a description below. --> | ||
<!-- | ||
Describe the changes made. | ||
What would someone unfamiliar with the project (but familiar with the codebase) need to understand what happened and why? | ||
--> | ||
|
||
## How to test | ||
## How to QA | ||
|
||
<!-- Add an explanation below for the reviewers to help them test your changes. --> | ||
<!-- | ||
Provide step-by-step instructions on how to verify the work. | ||
Use the canary build of the e2e packages (created via the `release_canary` CI job with this PR) | ||
If necessary, include details on how to test in production. | ||
|
||
Don't forget to test related features! | ||
--> | ||
|
||
1. | ||
|
||
Check ☑️ the appropriate box once you've finished QA: | ||
|
||
- [ ] Author - QA OK | ||
- [ ] Reviewer - QA OK | ||
|
||
## Release checklist | ||
|
||
<!-- | ||
If you're not publishing the packages to NPM, delete this section. | ||
--> | ||
|
||
- [ ] [Changeset](https://github.com/chromaui/chromatic-e2e/blob/main/DEVELOPMENT.md#pr-workflow-with-changesets) created in this PR |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Checking PR checklist | ||
permissions: read-all | ||
on: | ||
pull_request: | ||
types: [opened, edited, synchronize] | ||
|
||
jobs: | ||
check-pr-description: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- id: task-completed | ||
uses: chromaui/task-completed-checker-action@main | ||
with: | ||
repo-token: '${{ secrets.GITHUB_TOKEN }}' | ||
continue-on-error: true | ||
- name: Update Check (failure) | ||
if: steps.task-completed.outcome != 'success' | ||
uses: ouzi-dev/commit-status-updater@v2 | ||
with: | ||
name: PR Checklist | ||
status: pending | ||
description: Check off PR items to proceed | ||
- name: Update Check (success) | ||
if: steps.task-completed.outcome == 'success' | ||
uses: ouzi-dev/commit-status-updater@v2 | ||
with: | ||
name: PR Checklist | ||
status: success | ||
description: All tasks checked off! |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add this secret!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's created for me: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication