Merge pull request #194 from chromaui/andrew/ap-4963-add-extra-basic-…

…authentication-tests-in-e2e-to-ensure-we Add extra Basic Authentication tests in E2E
chromaui · Sep 4, 2024 · d13a446 · d13a446
2 parents e629f2b + f4b5c86
commit d13a446
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 6 deletions.
diff --git a/packages/cypress/tests/cypress/e2e/auth.cy.ts b/packages/cypress/tests/cypress/e2e/auth.cy.ts
@@ -0,0 +1,9 @@
+it('can succeed with basic authentication using locally defined credentials', () => {
+  cy.visit('/protected', {
+    auth: {
+      username: 'user',
+      password: 'secret',
+    },
+  });
+  cy.contains('I AM PROTECTED!!!').should('be.visible');
+});
diff --git a/packages/playwright/playwright.config.ts b/packages/playwright/playwright.config.ts
@@ -5,8 +5,8 @@ export default defineConfig({
   use: {
     baseURL: 'http://localhost:3000',
     httpCredentials: {
-      username: 'admin',
-      password: 'supersecret',
+      username: 'user',
+      password: 'secret',
     },
   },
   projects: [

diff --git a/packages/playwright/tests/auth.spec.ts b/packages/playwright/tests/auth.spec.ts
@@ -1,8 +1,26 @@
 import { test, expect } from '../src';
 
 test.describe(() => {
-  test('can login', async ({ page }) => {
-    await page.goto('/auth');
+  test('can succeed with basic authentication using globally-defined credentials', async ({
+    page,
+  }) => {
+    await page.goto('/protected');
+
+    await expect(page.getByText('I AM PROTECTED!!!')).toBeVisible();
+  });
+});
+
+test.describe(() => {
+  test.use({
+    extraHTTPHeaders: {
+      Authorization: `Basic ${btoa('admin:supersecret')}`,
+    },
+  });
+
+  test('can succeed with basic authentication using a locally-defined header that overrides globally-defined credentials', async ({
+    page,
+  }) => {
+    await page.goto('/admin');
 
     await expect(page.getByText('I AM PROTECTED!!!')).toBeVisible();
   });

diff --git a/test-server/server.js b/test-server/server.js
@@ -10,7 +10,15 @@ const htmlIntro = `<!doctype html><html>`;
 const htmlOutro = `</html>`;
 
 app.use(
-  '/auth',
+  '/protected',
+  basicAuth({
+    users: { user: 'secret' },
+    challenge: true,
+  })
+);
+
+app.use(
+  '/admin',
   basicAuth({
     users: { admin: 'supersecret' },
     challenge: true,
@@ -36,7 +44,11 @@ app.get('/img', (req, res) => {
   }
 });
 
-app.get('/auth', (req, res) => {
+app.get('/protected', (req, res) => {
+  res.sendFile(path.join(__dirname, 'fixtures/auth/index.html'));
+});
+
+app.get('/admin', (req, res) => {
   res.sendFile(path.join(__dirname, 'fixtures/auth/index.html'));
 });